Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not enough return values ​​in check_tap_output in case of TAP13 parse error #414

Closed
Astronomax opened this issue Nov 30, 2023 · 0 comments · Fixed by #425
Closed

Not enough return values ​​in check_tap_output in case of TAP13 parse error #414

Astronomax opened this issue Nov 30, 2023 · 0 comments · Fixed by #425
Assignees

Comments

@Astronomax
Copy link

Astronomax commented Nov 30, 2023

Most likely this happened in lib: propagate test status 'skip'.
check_tap_output (lib/test.py) is expected to return 3 values:

""" Returns is_tap, is_ok, is_skip """

However, if parsing fails, only 2 values ​​are returned:
return False, False

As a result, after running the tests I get the following output:

[001] replication-luatest/gh_9263_assertion_in_box_p>                 
[001] TAP13 parse failed (Descending test id on line: 'ok     1\tassertion-in-box-promote-qsync.test_is_in_box_promote').
[001] 
[001] No result file (replication-luatest/gh_9263_assertion_in_box_promote_qsync.result) found.
[001] Run the test with --update-result option to write the new result file.
[001] 
[001] Worker "001_replication-luatest" received the following error; stopping...
[001] Traceback (most recent call last):
[001]   File "/home/a-kuzdnets/tarantool3/test-run/lib/worker.py", line 347, in run_task
[001]     short_status, duration = self.suite.run_test(
[001]   File "/home/a-kuzdnets/tarantool3/test-run/lib/test_suite.py", line 277, in run_test
[001]     short_status = test.run(server)
[001]   File "/home/a-kuzdnets/tarantool3/test-run/lib/test.py", line 233, in run
[001]     is_tap, is_ok, is_skip = self.check_tap_output()
[001] ValueError: not enough values to unpack (expected 3, got 2)
[001] 
[001] Exception: not enough values to unpack (expected 3, got 2)
---------------------------------------------------------------------------------
@Astronomax Astronomax changed the title Not enough return values ​​in check_tap_output in case of TAP13 parse error. Not enough return values ​​in check_tap_output in case of TAP13 parse error Nov 30, 2023
@Astronomax Astronomax changed the title Not enough return values ​​in check_tap_output in case of TAP13 parse error Not enough return values ​​in check_tap_output in case of TAP13 parse error Nov 30, 2023
@Totktonada Totktonada self-assigned this Mar 11, 2024
Totktonada added a commit that referenced this issue Mar 11, 2024
The error is the following.

```
[050] unit/mp_tuple.test
[050] TAP13 parse failed (Missing plan in the TAP source).
[050]
[050] No result file (unit/mp_tuple.result) found.
[050] Run the test with --update-result option to write the new result file.
[050]
[050] Worker "050_unit" received the following error; stopping...
[050] Traceback (most recent call last):
[050]   File "/__w/tarantool/tarantool/test-run/lib/worker.py", line 347, in run_task
[050]     short_status, duration = self.suite.run_test(
[050]   File "/__w/tarantool/tarantool/test-run/lib/test_suite.py", line 277, in run_test
[050]     short_status = test.run(server)
[050]   File "/__w/tarantool/tarantool/test-run/lib/test.py", line 233, in run
[050]     is_tap, is_ok, is_skip = self.check_tap_output()
[050] ValueError: not enough values to unpack (expected 3, got 2)
[050] Exception: not enough values to unpack (expected 3, got 2)
```

The worker failure leads to the following error at end of the testing.

> [Internal test-run error] The following tasks were dispatched to some
> worker task queue, but were not reported as done (does not matters
> success or fail)

It is fixed now.

Follows up #381
Fixes #414
ylobankov pushed a commit that referenced this issue Mar 25, 2024
The error is the following.

```
[050] unit/mp_tuple.test
[050] TAP13 parse failed (Missing plan in the TAP source).
[050]
[050] No result file (unit/mp_tuple.result) found.
[050] Run the test with --update-result option to write the new result file.
[050]
[050] Worker "050_unit" received the following error; stopping...
[050] Traceback (most recent call last):
[050]   File "/__w/tarantool/tarantool/test-run/lib/worker.py", line 347, in run_task
[050]     short_status, duration = self.suite.run_test(
[050]   File "/__w/tarantool/tarantool/test-run/lib/test_suite.py", line 277, in run_test
[050]     short_status = test.run(server)
[050]   File "/__w/tarantool/tarantool/test-run/lib/test.py", line 233, in run
[050]     is_tap, is_ok, is_skip = self.check_tap_output()
[050] ValueError: not enough values to unpack (expected 3, got 2)
[050] Exception: not enough values to unpack (expected 3, got 2)
```

The worker failure leads to the following error at end of the testing.

> [Internal test-run error] The following tasks were dispatched to some
> worker task queue, but were not reported as done (does not matters
> success or fail)

It is fixed now.

Follows up #381
Fixes #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants