Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnect is used (why)? #46

Open
bigbes opened this issue Mar 10, 2017 · 0 comments
Open

Reconnect is used (why)? #46

bigbes opened this issue Mar 10, 2017 · 0 comments
Milestone
wishlist

Comments

@bigbes
Copy link
Contributor

bigbes commented Mar 10, 2017

Can't test transactions if switch command calls reconnect.
Gerold103 added a commit to tarantool/tarantool that referenced this issue Dec 3, 2019
@Gerold103
test: fix flaky box/gh-4627-session-use-after-free
f577002 
The problem was in that the test uses the global trigger
box.session.on_disconnect() to set a global variable by one
connection. But test-run can do multiple connects/reconnects to
the same instance. That led to multiple invocations of
box.session.on_disconnect(), which could override the global
variable in unexpected ways and moments.

The patch makes only one session execute that trigger.

Probably related to tarantool/test-run#46
Follow up #4627
Gerold103 added a commit to tarantool/tarantool that referenced this issue Dec 5, 2019
@Gerold103
test: fix flaky box/gh-4627-session-use-after-free
a93fa4b 
The problem was in that the test uses the global trigger
box.session.on_disconnect() to set a global variable by one
connection. But test-run can do multiple connects/reconnects to
the same instance. That led to multiple invocations of
box.session.on_disconnect(), which could override the global
variable in unexpected ways and moments.

The patch makes only one session execute that trigger.

Probably related to tarantool/test-run#46
Follow up #4627
Totktonada pushed a commit to tarantool/tarantool that referenced this issue Dec 5, 2019
@Gerold103 @Totktonada
test: fix flaky box/gh-4627-session-use-after-free
9643fdc 
The problem was in that the test uses the global trigger
box.session.on_disconnect() to set a global variable by one
connection. But test-run can do multiple connects/reconnects to
the same instance. That led to multiple invocations of
box.session.on_disconnect(), which could override the global
variable in unexpected ways and moments.

The patch makes only one session execute that trigger.

Probably related to tarantool/test-run#46
Follow up #4627

Reviewed-by: Alexander Turenko <alexander.turenko@tarantool.org>
Totktonada pushed a commit to tarantool/tarantool that referenced this issue Dec 5, 2019
@Gerold103 @Totktonada
test: fix flaky box/gh-4627-session-use-after-free
6e0dbe3 
The problem was in that the test uses the global trigger
box.session.on_disconnect() to set a global variable by one
connection. But test-run can do multiple connects/reconnects to
the same instance. That led to multiple invocations of
box.session.on_disconnect(), which could override the global
variable in unexpected ways and moments.

The patch makes only one session execute that trigger.

Probably related to tarantool/test-run#46
Follow up #4627

Reviewed-by: Alexander Turenko <alexander.turenko@tarantool.org>
(cherry picked from commit 9643fdc)
Totktonada pushed a commit to tarantool/tarantool that referenced this issue Dec 5, 2019
@Gerold103 @Totktonada
test: fix flaky box/gh-4627-session-use-after-free
073982c 
The problem was in that the test uses the global trigger
box.session.on_disconnect() to set a global variable by one
connection. But test-run can do multiple connects/reconnects to
the same instance. That led to multiple invocations of
box.session.on_disconnect(), which could override the global
variable in unexpected ways and moments.

The patch makes only one session execute that trigger.

Probably related to tarantool/test-run#46
Follow up #4627

Reviewed-by: Alexander Turenko <alexander.turenko@tarantool.org>
(cherry picked from commit 9643fdc)
@kyukhin kyukhin added this to the wishlist milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
wishlist
Development

No branches or pull requests
2 participants
@bigbes @kyukhin