Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tt clean lists snap/xlog thrice #735

Closed
DifferentialOrange opened this issue Dec 29, 2023 · 0 comments · Fixed by #837
Closed

tt clean lists snap/xlog thrice #735

DifferentialOrange opened this issue Dec 29, 2023 · 0 comments · Fixed by #837
Assignees
@DifferentialOrange

Comments

@DifferentialOrange
Copy link
Member

I have used the application from tarantool/crud#407

tt clean -f
   • List of files to delete:

   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/log/storage-a-001/tt.log
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-001/00000000000000000000.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-001/00000000000000000000.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-001/00000000000000000000.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-001/00000000000000000000.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-001/00000000000000000000.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-001/00000000000000000000.xlog
   • storage-a-001: cleaning...	[ERR] remove /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-001/00000000000000000000.snap: no such file or directory
   • List of files to delete:

   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/log/storage-a-002/tt.log
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-002/00000000000000000031.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-002/00000000000000000031.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-002/00000000000000000031.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-002/00000000000000000031.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-002/00000000000000000031.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-002/00000000000000000031.xlog
   • storage-a-002: cleaning...	[ERR] remove /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-a-002/00000000000000000031.snap: no such file or directory
   • List of files to delete:

   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/log/storage-b-001/tt.log
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-b-001/00000000000000000000.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-b-001/00000000000000000000.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-b-001/00000000000000000000.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-b-001/00000000000000000000.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-b-001/00000000000000000000.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-b-001/00000000000000000000.xlog
   • storage-b-001: cleaning...	[ERR] remove /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/storage-b-001/00000000000000000000.snap: no such file or directory
   • List of files to delete:

   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/log/storage-b-002/tt.log
   • storage-b-002: cleaning...	[OK]
   • List of files to delete:

   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/log/router-a-001/tt.log
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000000.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000000.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000013.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000000.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000000.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000013.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000000.snap
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000000.xlog
   • /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000013.xlog
   • router-a-001: cleaning...	[ERR] remove /home/moiseevgeorgy/Development/github/tarantool/crud/cluster/var/lib/router-a-001/00000000000000000000.snap: no such file or directory
   • List of files to delete:

   • /home/moiseevgeorgy/Development/github/tarantool/crud/crud/var/log/crud/tt.log
   • crud: cleaning...	[OK]
@DifferentialOrange DifferentialOrange changed the title tt clean list files multiple times tt clean lists files multiple times Dec 29, 2023
@DifferentialOrange DifferentialOrange changed the title tt clean lists files multiple times tt clean lists snap/xlog thrice Dec 29, 2023
@DifferentialOrange DifferentialOrange mentioned this issue Apr 5, 2024
Closed
@DifferentialOrange DifferentialOrange self-assigned this May 3, 2024
DifferentialOrange added a commit that referenced this issue May 3, 2024
@DifferentialOrange
test: assert tt clean removes snap and xlog files
f7bfc21 
Before this patch, `tt clean` test had asserted that it removes a log
file foran application without box.cfg bootstrap. Now it works with
a real application with snap and xlog files and asserts that they are
removed as well.

Part of #735
DifferentialOrange added a commit that referenced this issue May 3, 2024
@DifferentialOrange
clean: fix attempt to remove files multiple times
e28ea2f 
Before this patch, `tt clean` could list files multiple times since it
is possible that memtx_dir, wal_dir, vinyl_dir and log_dir are the same
directory (and the first three are the same by default). It also had
tried to removed them several times, which had resulted in `[ERR]`
message in logs. This patch fixes the issue.

Closes #735
@DifferentialOrange DifferentialOrange mentioned this issue May 3, 2024
Merged
DifferentialOrange added a commit that referenced this issue May 3, 2024
@DifferentialOrange
test: assert tt clean removes snap and xlog files
9ee787f 
Before this patch, `tt clean` test had asserted that it removes a log
file fo ran application without box.cfg bootstrap. Now it works with
a real application with snap and xlog files and asserts that they are
removed as well.

Part of #735
DifferentialOrange added a commit that referenced this issue May 3, 2024
@DifferentialOrange
clean: fix attempt to remove files multiple times
2563bef 
Before this patch, `tt clean` could list files multiple times since it
is possible that memtx_dir, wal_dir, vinyl_dir and log_dir are the same
directory (and the first three are the same by default). It also had
tried to removed them several times, which had resulted in `[ERR]`
message in logs. This patch fixes the issue.

Closes #735
DifferentialOrange added a commit that referenced this issue May 3, 2024
@DifferentialOrange
test: assert tt clean removes snap and xlog files
199edf5 
Before this patch, `tt clean` test had asserted that it removes a log
file fo ran application without box.cfg bootstrap. Now it works with
a real application with snap and xlog files and asserts that they are
removed as well.

Part of #735
DifferentialOrange added a commit that referenced this issue May 3, 2024
@DifferentialOrange
clean: fix attempt to remove files multiple times
cc28ff5 
Before this patch, `tt clean` could list files multiple times since it
is possible that memtx_dir, wal_dir, vinyl_dir and log_dir are the same
directory (and the first three are the same by default). It also had
tried to removed them several times, which had resulted in `[ERR]`
message in logs. This patch fixes the issue.

Closes #735
psergee pushed a commit that referenced this issue May 6, 2024
@DifferentialOrange @psergee
test: assert tt clean removes snap and xlog files
e5430ad 
Before this patch, `tt clean` test had asserted that it removes a log
file fo ran application without box.cfg bootstrap. Now it works with
a real application with snap and xlog files and asserts that they are
removed as well.

Part of #735
psergee pushed a commit that referenced this issue May 6, 2024
@DifferentialOrange @psergee
clean: fix attempt to remove files multiple times
d81ca3a 
Before this patch, `tt clean` could list files multiple times since it
is possible that memtx_dir, wal_dir, vinyl_dir and log_dir are the same
directory (and the first three are the same by default). It also had
tried to removed them several times, which had resulted in `[ERR]`
message in logs. This patch fixes the issue.

Closes #735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DifferentialOrange DifferentialOrange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean: fix attempt to remove files multiple times tarantool/tt
1 participant
@DifferentialOrange