Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix no line numbers shown for golangci #116

Merged
merged 1 commit into from
Aug 10, 2022
Merged

ci: fix no line numbers shown for golangci #116

merged 1 commit into from
Aug 10, 2022

Conversation

0x501D
Copy link
Member

@0x501D 0x501D commented Aug 10, 2022

Solution is taken from:
golangci/golangci-lint-action#119 (comment)

@0x501D 0x501D force-pushed the 0x501D/fix_ci_linter_outout branch from dc1b5fb to 4e80bc2 Compare August 10, 2022 11:29
@0x501D 0x501D requested a review from LeonidVas August 10, 2022 11:32
@0x501D
Copy link
Member Author

0x501D commented Aug 10, 2022

Test commit was shown with line numbers and file name:
https://github.com/tarantool/tt/runs/7765606513?check_suite_focus=true

LeonidVas
LeonidVas approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
If it works fine. I'm ok.

@LeonidVas LeonidVas merged commit 0dc3e90 into master Aug 10, 2022
@LeonidVas LeonidVas deleted the 0x501D/fix_ci_linter_outout branch August 10, 2022 11:39
@oleg-jukovec oleg-jukovec mentioned this pull request Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonidVas LeonidVas LeonidVas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x501D @LeonidVas