Implementation of `tt connect' #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonidVas
force-pushed
the
lvasiliev/gh-15-connect
branch
from
1e6628c
to
80245e2
Compare
0x501D
reviewed
Apr 19, 2022
0x501D
reviewed
Apr 19, 2022
0x501D
reviewed
Apr 19, 2022
0x501D
reviewed
Apr 19, 2022
0x501D
approved these changes
Apr 19, 2022
The minimum required part of the connect module from the cartridge-cli (https://github.com/tarantool/cartridge-cli) was copied without any changes. Part of #15
Closed
LeonidVas
force-pushed
the
lvasiliev/gh-15-connect
branch
from
80245e2
to
45e892f
Compare
As far as the module has been copied from cartridge-cli without any changes, this patch has the following targets: * add a description for public methods * remove unneeded code * squash similar part of code Part of #15
The patch adds `eval` functionality to the connect module. Now, if code has been passed in by a command, it will be executed on the instance and the result (in YAML format) will be returned to `stdout`. Part of #15
The patch adds a workaround for the bug "Terminal does not display command after go-prompt exit" (c-bata/go-prompt#228). Part of #15
Follow-up #15
The patch adds information about `tt connect` module to CHANGELOG and README. Follow-up #15
LeonidVas
force-pushed
the
lvasiliev/gh-15-connect
branch
from
45e892f
to
defae9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the
tt connectmodule.