test: verify incorrect keys in :compare_with_key() #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module is not affected by the problem, so this commit only adds the relevant test case. See details in tarantool/tarantool#5307 Fixes #7.
Totktonada
force-pushed
the
void234/add-test-part-count-check
branch
from
877d87b
to
e7730a9
Compare
Totktonada
changed the title
Totktonada
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Thanks!
I made several tiny changes to keep the code style a bit more uniform and added a bit more details into the commit message, the test case comment and the PR description. I hope you don't mind.
Verified on tarantool 2.7.0-74-g71377c28e and 1.10.8-55-gddd6a342b.
The test looks good for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module is not affected by the problem, so this commit only adds the
relevant test case.
See details in tarantool/tarantool#5307
Fixes #7.