Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using camera as input on mobile with gpt-4 vision #302

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

mingming-ma
Copy link
Collaborator

@mingming-ma mingming-ma commented Nov 27, 2023

Fix #282

Status

image

image

image

Tasks

Copy link

sweep-ai bot commented Nov 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@mingming-ma mingming-ma marked this pull request as ready for review November 27, 2023 20:31
@humphd
Copy link
Collaborator

humphd commented Nov 29, 2023

This branch cannot be rebased due to conflicts

Same issue here.

Tested this with other users, and their feedback was:

  1. Optimize the image locally so upload is faster
  2. There's a lot of horizontal scrolling on mobile (might be unrelated to this PR)
  3. The icon on mobile should probably be a camera
  4. Support the camera use case, but also attaching a photo from the camera roll

Copy link

cloudflare-pages bot commented Dec 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fa1a542
Status: ✅  Deploy successful!
Preview URL: https://1dba1606.console-overthinker-dev.pages.dev
Branch Preview URL: https://issue-282.console-overthinker-dev.pages.dev

View logs

@tarasglek
Copy link
Owner

tarasglek commented Dec 21, 2023

edit, nm saw other issue

@mingming-ma mingming-ma added this to the Release 1.3 milestone Feb 7, 2024
@mingming-ma
Copy link
Collaborator Author

@humphd Just tested mobile version and sending images works well.

Since the Attach button is moved to the Options button, I removed the mobile view's Camera button, and user can add photos or take pictures from the Options button -> Attach Files.... and update the UI if needed in follow up PRs, Sounds good?

Copy link
Collaborator

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. When we start supporting other image types, we might want to separate "use camera" from "attach image", but let's wait.

@WangGithub0 WangGithub0 self-requested a review February 14, 2024 16:12
Copy link
Collaborator

@WangGithub0 WangGithub0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
photo library, take phone, choose files all work perfect.

@mingming-ma mingming-ma merged commit 61a2b51 into main Feb 14, 2024
4 checks passed
@humphd
Copy link
Collaborator

humphd commented Feb 15, 2024

This is so, so cool! Just used it to take a picture of hand-written notes in order to get text. 💯

@mingming-ma mingming-ma deleted the issue-282 branch April 10, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using camera as input on mobile with gpt-4 vision
4 participants