Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html not syntax highlight #430

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix html not syntax highlight #430

merged 2 commits into from
Feb 9, 2024

Conversation

mingming-ma
Copy link
Collaborator

Fixes #429

This is weird, because I couldn't find the html language from the demo list react-syntax-highlighter. Currently I can see it is default use text type for the html from developer tools.

I trying to use htmlbars to solve this issue.

Copy link
Collaborator

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense to me, it's worked for months.

Can we git bisect to see what broke it?

@mingming-ma
Copy link
Collaborator Author

Yeah, sure, somehow I find this deployed still not working.

@mingming-ma
Copy link
Collaborator Author

It may at least exists long time, see here the screenshots from my PR from October https://github.com/tarasglek/chatcraft.org/assets/133393905/49bb9503-69dd-4b59-a24a-249ecb4e19b7

@humphd
Copy link
Collaborator

humphd commented Feb 9, 2024

Amazing. Maybe we're wrong and this never worked (cc @tarasglek)? Looks like people use xml as the language for HTML content with highlight.js

Copy link

cloudflare-pages bot commented Feb 9, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd4d486
Status: ✅  Deploy successful!
Preview URL: https://a3bae363.console-overthinker-dev.pages.dev
Branch Preview URL: https://mingming-syntax-highlight-42.console-overthinker-dev.pages.dev

View logs

@mingming-ma
Copy link
Collaborator Author

It works! xml more suitable 👍 There is some difference between local and cloud, maybe from OS, my htmlbars version is also working locally, and I don't know why first try fails. Maybe we can solve by this way for now.

@humphd humphd added this to the Release 1.2 milestone Feb 9, 2024
@humphd humphd merged commit cdd3fbb into main Feb 9, 2024
4 checks passed
@tarasglek
Copy link
Owner

Nice find, that's amazing that we both hallucinated it working

@mingming-ma mingming-ma deleted the mingming/syntax-highlight#429 branch April 10, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] HTML content not being syntax-highlighted anymore
3 participants