Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewport pushed by switching chats #445

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix viewport pushed by switching chats #445

merged 1 commit into from
Feb 14, 2024

Conversation

Amnish04
Copy link
Collaborator

@Amnish04 Amnish04 commented Feb 13, 2024

This fixes #442

Just re-read my blog post for the solution
https://dev.to/amnish04/no-backing-away-when-hacking-away-2h27

When the page is loaded and the options menu is never opened, the menu list is overflowing below the visible page, effectively creating hidden scrollbars.
image

The view is fixed when you open the menu at least once
image

But setting the position to fixed eliminates the issue altogether

@Amnish04 Amnish04 added the hotfix a small piece of code developed to correct a major software bug and released as quickly as possible label Feb 13, 2024
@Amnish04 Amnish04 added this to the Release 1.3 milestone Feb 13, 2024
@Amnish04 Amnish04 self-assigned this Feb 13, 2024
Copy link
Collaborator

@rjwignar rjwignar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this fixes the problem.
Read your blog too.
It's amazing how helpful it is to blog our work!

Now, does this mean every ChakraUI Menu component added in the future must have strategy value of fixed?

@Amnish04
Copy link
Collaborator Author

Amnish04 commented Feb 13, 2024

@rjwignar That is so true, my blogs have saved me many times lol

About setting it to all menus, I am not too sure. Maybe only to ones that cause problems?
@humphd What do you think?

@humphd
Copy link
Collaborator

humphd commented Feb 13, 2024

I'm also worried about the fact that we have 2 menus now. I'm sure that within the next week or two, this options menu will need sub-menus, and then we'll have to switch to the new menu component. Does it need this fix?

I think we need to fix this once for all time. What if @Amnish04 isn't around to save us?

@humphd
Copy link
Collaborator

humphd commented Feb 13, 2024

If you want to land this in the mean time and do a better fix later, that's fine too.

@Amnish04 Amnish04 merged commit 840c9f5 into main Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix a small piece of code developed to correct a major software bug and released as quickly as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page Moves Up When Clicking Saved Chat
3 participants