Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced padding to use relative value #462

Closed
wants to merge 1 commit into from
Closed

Replaced padding to use relative value #462

wants to merge 1 commit into from

Conversation

Rachit1313
Copy link
Collaborator

@Rachit1313 Rachit1313 commented Feb 16, 2024

  • @Amnish04 and I noticed that the alignment was perfect on a 13 inch macbook whereas was wrong in a monitor of a bigger size.
  • Changed padding value to use relative % so that it should adjust according to screen width.

Fixes #453

@Rachit1313 Rachit1313 added this to the Release 1.3 milestone Feb 16, 2024
@Rachit1313 Rachit1313 self-assigned this Feb 16, 2024
Copy link
Collaborator

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still wrong:

Screenshot 2024-02-16 at 8 43 05 AM

I think it should be identical to the content above it.

@Rachit1313
Copy link
Collaborator Author

This is still wrong:

Screenshot 2024-02-16 at 8 43 05 AM I think it should be identical to the content above it.

Its a bit confusing in this one. I fixed this based on a monitor with windows, it broke in mac. In our production it is perfect in mac even if I change the zoom scaling to any %.

image

@Amnish04
Copy link
Collaborator

If you look closely, both GridItems are same width and centred correctly. But its the scrollbar that's pushing our chat area away
image

One thing we can do is set a left margin equal to width of scrollbar, but I don't know how we can get that width as its different across browsers and platforms.
@humphd Can we really fix this?

@humphd
Copy link
Collaborator

humphd commented Feb 16, 2024

OK, if it's per-platform stuff with scrollbars, we probably won't ever win this battle. Maybe we should close?

@Amnish04
Copy link
Collaborator

OK, if it's per-platform stuff with scrollbars, we probably won't ever win this battle. Maybe we should close?

I agree, lets close it.

@Rachit1313 Rachit1313 closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat Area and Prompt Menu are not aligned perfectly
3 participants