Replace "Cancel Adding Provider" SVG with an IconButton #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying chatcraft-org with
|
| Latest commit: |
0a573b9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1522b6ab.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://amnish04-issue-551.console-overthinker-dev.pages.dev |
|
@kliu57 I have fixed the alignment issue you mentioned |
kliu57
requested changes
Apr 3, 2024
There was a problem hiding this comment.
it's causing the column headings as well as the data underneath the new row to shift to the right the moment we add the new row. I think it is due to the padding/margin of the iconbutton being greater than the padding/margin around the checkboxes. Can you fix it so there is no shift?
|
@kliu57 Just pushed the fix for that |
kliu57
requested changes
Apr 3, 2024
|
Thanks for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #530 (comment), we should not use Svg's directly as an alternative of a button since it is semantically incorrect.
https://www.reddit.com/r/webdev/comments/r72zq6/comment/hmwvobm/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
I tried preserving the look of the button, and was successful for the most part.
Normal:
Active:
This fixes #551