Updated regex to ignore backslash

[Rachit1313]

Closes #427

Changes Made:

Updated regex to ignore backslash in github commands.

How to test:

Both the links with backslash at the end or without would recieve diff when a link of github PR is imported using /import command.

[cloudflare-pages]

Deploying chatcraft-org with    Cloudflare Pages

Latest commit:	4ea670d
Status:	✅  Deploy successful!
Preview URL:	https://8e430d3b.console-overthinker-dev.pages.dev
Branch Preview URL:	https://issue-427.console-overthinker-dev.pages.dev

View logs

[kliu57]

Behaviour is different for /import https://github.com/tarasglek/chatcraft.org/pull/421

Than /import http://github.com/tarasglek/chatcraft.org/pull/421

Moreover, behaviour is different from production for /import https://github.com/tarasglek/chatcraft.org/pull/421/ and all others

Output stops at line 83

Also, sorry about the PR close then reopen thing, I needed to close my PR and I clicked the button on the wrong one.

[humphd]

# Works
/import https://github.com/tarasglek/chatcraft.org/blob/main/.eslintignore

# Fails
/import https://github.com/tarasglek/chatcraft.org/blob/main/.eslintignore/

The latter returns a 400 from the server

[Rachit1313]

I just verified that this is something we have in production as well

[humphd]

Do you want to fix it while you're working on this or split it off into a future issue?

[Rachit1313]

I would like to work on debugging this, but as this PR fixes the problem for PRs and gist, i would like to get this merged and create another issue and PR for that one.

[Rachit1313]

@kliu57 , for me both the import command on PR 412 without backslash returns the same number of lines i.e 83 in production as well in my branch preview URL.

[Rachit1313]

@kliu57 And for the second part i.e difference between https and http, I believe this is because we are only looking for https in the origin of the URL to confirm if we want to rewrite this with github-rewriters.ts. Everywhere in our code we used https to verify.

I am not sure, just guessing, @humphd would be able to answer this.

[humphd]

@kliu57 , for me both the import command on PR 412 without backslash returns the same number of lines i.e 83 in production as well in my branch preview URL.

this is likely due to it being a diff, with only ~6 lines of context (so it naturally cuts if off), which is normal.

[humphd]

@kliu57 And for the second part i.e difference between https and http, I believe this is because we are only looking for https in the origin of the URL to confirm if we want to rewrite this with github-rewriters.ts. Everywhere in our code we used https to verify. I am not sure, just guessing, @humphd would be able to answer this.

I think requiring HTTPS is fine.

[mingming-ma]

Here is comparing results:

	Prod	This PR
import https, has end slash
import https, no end slash
import http, has end slash
import http, no end slash

By my understanding, it fixes the issue, and code changes LGTM!

[Rachit1313]

I think we're good to land this. I'll fix for 400 error of blob as a separate issue.

[rjwignar]

These changes LGTM.
I think the Blob URL issue can be resolved in a followup.