Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed icon open raw feed #573

Merged
merged 3 commits into from Apr 12, 2024
Merged

Feed icon open raw feed #573

merged 3 commits into from Apr 12, 2024

Conversation

WangGithub0
Copy link
Collaborator

Change Feed icon directly open raw feed tab

closes #572

@WangGithub0 WangGithub0 added this to the Release 1.9 milestone Apr 8, 2024
@WangGithub0 WangGithub0 self-assigned this Apr 8, 2024
Copy link

cloudflare-pages bot commented Apr 8, 2024

Deploying chatcraft-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 80438dd
Status: ✅  Deploy successful!
Preview URL: https://81be1f52.console-overthinker-dev.pages.dev
Branch Preview URL: https://issue-572.console-overthinker-dev.pages.dev

View logs

Copy link
Collaborator

@Amnish04 Amnish04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WangGithub0 The code looks good, and the button leads us to a new tab now.

I had a question. Clicking this button downloads a .atom file for me, which gives me an error when trying to import in Feeder. Is this the expected behaviour or should we be seeing XML for the feed?

@Rachit1313
Copy link
Collaborator

Rachit1313 commented Apr 12, 2024

@WangGithub0 The code looks good, and the button leads us to a new tab now.

I had a question. Clicking this button downloads a .atom file for me, which gives me an error when trying to import in Feeder. Is this the expected behaviour or should we be seeing XML for the feed?

Hi Amnish,
Which OS did you test this on. i tested it today on macOS but no file was downloaded for me and I was redirected to a new tab with the feed? Is the above behavior OS specific?

@WangGithub0
Copy link
Collaborator Author

@Amnish04 @Rachit1313 thanks for your testing, my test is open a new tab with feed.atom file.

@Amnish04
Copy link
Collaborator

@WangGithub0 The code looks good, and the button leads us to a new tab now.
I had a question. Clicking this button downloads a .atom file for me, which gives me an error when trying to import in Feeder. Is this the expected behaviour or should we be seeing XML for the feed?

Hi Amnish, Which OS did you test this on. i tested it today on macOS but no file was downloaded for me and I was redirected to a new tab with the feed? Is the above behavior OS specific?

@Rachit1313 I am using Firefox on Windows 10. But for me, a file gets downloaded

@Amnish04
Copy link
Collaborator

@Amnish04 @Rachit1313 thanks for your testing, my test is open a new tab with feed.atom file.

@WangGithub0 Yes, the new tab is opening. Just that the file gets downloaded. Maybe my browser issue?

@WangGithub0
Copy link
Collaborator Author

@Amnish04 @Rachit1313 thanks for your testing, my test is open a new tab with feed.atom file.

@WangGithub0 Yes, the new tab is opening. Just that the file gets downloaded. Maybe my browser issue?

could you try this "open code in new window" button?
image

@Rachit1313
Copy link
Collaborator

@Amnish04 , I even tested it on my Windows Chrome and it works well for me and no file is downloaded. Maybe its something firefox related.

@Rachit1313
Copy link
Collaborator

image
macOS safari

Copy link
Collaborator

@Amnish04 Amnish04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something specific to my browser I guess if its working for everyone else.

Looks good otherwise!

@Rachit1313 Rachit1313 merged commit f66f24c into main Apr 12, 2024
4 checks passed
@WangGithub0 WangGithub0 deleted the issue-572 branch April 13, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feed icon should open raw feed
3 participants