Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable edit summary for shared chats #598

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Disable edit summary for shared chats #598

merged 2 commits into from
Apr 18, 2024

Conversation

WangGithub0
Copy link
Collaborator

before:
image

after:
image

closes #160

@kliu57 kliu57 added this to the Release 2.0 milestone Apr 17, 2024
kliu57
kliu57 requested changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@kliu57 kliu57 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe you could also get rid of the divider

image

If it is difficult to do, then it probably is not worth it, then can just skip this

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Apr 17, 2024 •
edited
Loading

Deploying chatcraft-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 020ec78
Status: ✅  Deploy successful!
Preview URL: https://158f58b7.console-overthinker-dev.pages.dev
Branch Preview URL: https://issue-160.console-overthinker-dev.pages.dev

View logs

@WangGithub0 WangGithub0 requested a review from kliu57 April 17, 2024 17:55
kliu57
kliu57 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@kliu57 kliu57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Amnish04
Amnish04 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@Amnish04 Amnish04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WangGithub0 Looks good to me!

@WangGithub0 WangGithub0 merged commit 23af50d into main Apr 18, 2024
4 checks passed
@WangGithub0 WangGithub0 deleted the issue-160 branch April 18, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amnish04 Amnish04 Amnish04 approved these changes

@kliu57 kliu57 kliu57 approved these changes

@mingming-ma mingming-ma Awaiting requested review from mingming-ma

Assignees

@WangGithub0 WangGithub0

Labels
None yet
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging this pull request may close these issues.

Disable edit/delete for shared chats
3 participants
@WangGithub0 @Amnish04 @kliu57