Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better progressbar unit names #2

Merged
merged 1 commit into from
Jan 4, 2016

Conversation

pokab
Copy link
Contributor

@pokab pokab commented Jan 1, 2016

The default "byte" was misleading.

@taraslayshchuk
Copy link
Owner

kdocs per second and klines per second look like not clear for me.

@pokab
Copy link
Contributor Author

pokab commented Jan 4, 2016

OK. Are we on the same page with respect to bytes and kB being totally wrong here?
As I understand Elasticsearch concepts, documents are being fetched here, so that is why I thought "doc" was ok. Maybe "Documents" would be better.
When converting to CSV, lines are being processed, so I wrote "lines".
What would you like?

@taraslayshchuk
Copy link
Owner

I think kB/s has a place to be there, because it shows speed of downloading data and writing to disc. For documents and lines we have counter:

Run query [##################] [91440/91440] [100%] [0:00:07] [Time: 0:00:07] [ 12.62 kB/s]

                                /         \
                      current doc         total docs

Write to csv [########________] [63206/91440] [ 69%] [0:00:01] [ETA: 0:00:00] [ 31.61 kB/s]

                                /         \
                      current line         total lines

And anyway the measurements kdocs/s and klines/s confuses me, so it could be just removed.

@pokab
Copy link
Contributor Author

pokab commented Jan 4, 2016

I think kB/s has a place to be there, because it shows speed of downloading data and writing to disc.

The only reason for me to touch this was that it is not the speed of the download or writing to disk. Instead of bytes, the program accounts for downloaded documents (records) and lines instead. It has no information about bytes at all. The actual speed is orders of magnitude faster (as it should be), which is why I discovered this in the first place.
I'm not sure why you're confused about non-byte/s measurement, it is simply the speed of the progressbar filling up.

@taraslayshchuk
Copy link
Owner

I reviewed scrutinized speed values which you talking about and I realized that you are right, it is really docs per second, just in my case it is kdocs(1024*docs) and in some case it is shock.
Good job, thank you!

taraslayshchuk added a commit that referenced this pull request Jan 4, 2016
better progressbar unit names
@taraslayshchuk taraslayshchuk merged commit 600cf31 into taraslayshchuk:master Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants