Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket configuration to Tarbell configure #59

Closed
eads opened this issue Nov 20, 2013 · 4 comments
Closed

Add bucket configuration to Tarbell configure #59

eads opened this issue Nov 20, 2013 · 4 comments
Labels
Milestone

Comments

@eads
Copy link
Contributor

eads commented Nov 20, 2013

Dropping s3cmd means not calling the s3cmd --configure command from configure.py and instead asking about and writing some values to our configuration file ourselves. Bonus points if it can configure buckets by name, but that could be a beta-4 task, too.

@ghost ghost assigned rnagle Nov 20, 2013
@rnagle
Copy link
Contributor

rnagle commented Dec 8, 2013

I'd say a first pass at this task is done. A few ideas came out of working through this...

  • It might be nice to have a tarbell configure s3 command that walks through configuring s3 buckets only.
  • How can we ease the transition for folks upgrading from and older version of Tarbell? Attempting to use an older config with these changes will break the Tarbell publish process.

Any others?

@eads
Copy link
Contributor Author

eads commented Dec 8, 2013

Is there a way to detect an older config and prompt to upgrade?
On Dec 8, 2013 8:56 AM, "Ryan Nagle" notifications@github.com wrote:

I'd say a first pass at this task is done. A few ideas came out of working
through this...

  • It might be nice to have a tarbell configure s3 command that walks
    through configuring s3 buckets only.
  • How can we ease the transition for folks upgrading from and older
    version of Tarbell? Attempting to use an older config with these changes
    will break the Tarbell publish process.

Any others?


Reply to this email directly or view it on GitHubhttps://github.com//issues/59#issuecomment-30083120
.

@eads
Copy link
Contributor Author

eads commented Dec 9, 2013

I finally got a chance to look at this. Nice work! I have a concern, though: We need to keep s3 creds out of tarbell_config.py. I think the config file needs to somehow account for this, so that it keys off the bucket name:

default_s3_key_id: <DEFAULTKEYID>
default_s3_access_key: <DEFAULTACCESSKEY>
s3_creds:
  myspecialapp.chicagotribune.com:
    access_key_id: <KEYID>
    secret_access_key: <SECRETKEY>
default_buckets:
   production: s3://apps.chicagotribune.com/

What do you think? The primary need is to keep secrets out of Tarbell project files so they can be readily released as open source projects.

@ghost ghost assigned eads Dec 10, 2013
@eads
Copy link
Contributor Author

eads commented Dec 13, 2013

Finally fixed, with an upgrade message for folks on beta2 and below.

@eads eads closed this as completed Dec 13, 2013
@eads eads removed their assignment Nov 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants