Fix file paths at diff step in release pipeline
#1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epassaro
changed the title
tardis repo path in release pipeline
epassaro
changed the title
tardis repo path in release pipelinediff step in release pipeline
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* Fix tardis repo directory path * Fix tardis repo directory path (again) * Enable the pipeline for this PR * Enable the pipeline for this PR (again) * Enable the pipeline for this PR (again) * Fix tardis repo directory path (again) * Fix tardis repo directory path (again) * Fix tardis repo directory path (again) * Fix tardis repo directory path (again) * Fix tardis repo directory path (again) * Final changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release pipeline is failing because changes made in PR #1040 introduced an incorrect path of both JSON files, then the
diffcommand fails.This bug is already fixed, and the pipeline is working as expected (see build log). Now the pipeline fails because one author modified his ORCID information, then the
diffstep stops the build process. But this is ok!.The new JSON (with updated ORCID data) is updated as an artifact in the failed pipeline build log, and we need to push it to the
masterbranch and re-run the pipeline (see #1046). Then the pipeline must pass.This should be our workflow until somone splits this pipeline in two parts and we are capable of pushing files from Azure to TARDIS main repository.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: