Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed capmanager class functions to its new ones #1055

Merged
merged 1 commit into from Feb 29, 2020

Conversation

not4win
Copy link
Contributor

@not4win not4win commented Feb 26, 2020

From pytest version 3.3.0+, the capmanager.suspendcapture and capmanager.resumecapture were renamed to capmanager.suspend_global_capture and capmanager.resume_global_capture, respectively.
The pytest version used here is 4.

@marxwillia
Copy link
Contributor

@not4win please be more descriptive with your PR. Why are these changes necessary? If they address errors, document them. Does this require a change of the tardis_env.yml file?

@not4win
Copy link
Contributor Author

not4win commented Feb 27, 2020

tardis_env.yml file has pytest version 4.
From pytest version 3.3.0+, the capmanager's suspendcapture and resumecapture functions have been renamed.
Hence they give out error. (Present in test_integration.py file)
These functions have been renamed to capmanager.suspend_global_capture and capmanager.resume_global_capture, respectively.
No change in tardis_env.yml is required. Just renaming them is sufficient.
Reference: https://stackoverflow.com/questions/42760059/how-to-make-pytest-wait-for-manual-user-action (the first solution)

@epassaro
Copy link
Member

epassaro commented Feb 28, 2020

@not4win is right, method resumecapture was renamed to resume_global_capture in pytest-dev/pytest#2801

@wkerzendorf wkerzendorf merged commit 847b562 into tardis-sn:master Feb 29, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants