NLTE fixes - discussion needed before merge - relates to #109 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,7 +92,9 @@ class BasePlasmaArray(object): | |||
| """ | |||
|
|
|||
| @classmethod | |||
| def from_abundance(cls, abundance_dict, density, atom_data, time_explosion, nlte_config=None, saha_treatment='lte'): | |||
| def from_abundance(cls, abundance_dict, density, atom_data, time_explosion, | |||
| nlte_config=None, ionization_mode='lte', | |||
There was a problem hiding this comment.
shouldn't this be 1 instead of None. This is like in #53
There was a problem hiding this comment.
for i in range(20):
print i
|
Tests are now in place. Bug fixes have been attempted. This version should now be considered possible for merging. |
Plasma/fix nlte tests
fixing up the NLTE tests
|
passed: Travis says "yes" |
ssim
added a commit
that referenced
this pull request
Apr 16, 2014
NLTE fixes - discussion needed before merge - relates to #109
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary:
(calculate_nlte_level_populations)
longer handled as negative absorption (correction factor removed
from calculate_nlte_level_populations / reformulated terms)
LTE check made using this version He I and He II, but reproducible test case needed - this needs to be discussed/explained how to insert set up.
@wkerzendorf look at the change proposed in the formulation of the rate equations. Does this look problematic? This relates to the suggestion in #109
Do not recommend merging this until it has been discussed fully.