Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arjun's name to the ORCID list #1197

Merged
merged 2 commits into from Jun 24, 2020
Merged

add arjun's name to the ORCID list #1197

merged 2 commits into from Jun 24, 2020

Conversation

arjunsavel
Copy link
Contributor

Description

I'm adding my ORCID to the list that TARDIS references.

Motivation and Context

We'd like to make sure our ORCID list is up-to-date.

How Has This Been Tested?

N/A (as far as I know!)

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1197   +/-   ##
=======================================
  Coverage   77.73%   77.73%           
=======================================
  Files          92       92           
  Lines        5731     5731           
=======================================
  Hits         4455     4455           
  Misses       1276     1276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19beeec...c6827ce. Read the comment docs.

@wkerzendorf
Copy link
Member

is this the email you use with your github?

@wkerzendorf wkerzendorf merged commit 95a6b36 into master Jun 24, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* add arjun's name to the ORCID list

* Update .orcid.csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants