Issue #107: Tried to resolve the missing collisional data while getting NLTE data problem #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssim Please review this. I shall be grateful if you can also suggest me a more proper error message. |
| try: | ||
| c_ul_matrix = self.C_ul_interpolator[species](t_electrons) | ||
| except AttributeError: | ||
| print "Collisional Data missing. Unable to create Collision Matrix for NLTE Data." |
There was a problem hiding this comment.
@rajul-iitkgp thanks for trying to fix this. I think the first is to remove the print-statement. I think in this case the code should stop, so when you catch the AttributeError - it would be great to reraise it with the error message you give (maybe then re-raise it as a ValueError). Thanks
|
Hello - I think the text of the message above it good: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.