Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily fetch refdata from GDrive #1267

Merged
merged 10 commits into from Aug 7, 2020

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Aug 6, 2020

Description

Retrieve TARDIS reference data from a backup stored in Google Drive.

Motivation and Context

We exceeded our LFS quota by mistake :(

How Has This Been Tested?

Testing pipeline is passing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1267 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1267   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          41       41           
  Lines        3424     3424           
=======================================
  Hits         2761     2761           
  Misses        663      663           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ec390...d030690. Read the comment docs.

displayName: "Fetch reference data"
condition: false

Copy link
Member Author

@epassaro epassaro Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed the plasma_reference folder (does not exist in tardis-sn/tardis-refdata repo) and disabled the step with the false condition. The rest of the lines were shifted by the YAML autoformatter.

pytest tardis --tardis-refdata=$(ref.data.home) --cov=tardis --cov-report=xml --cov-report=html
source activate tardis
pip install pytest-azurepipelines
pytest tardis --tardis-refdata=$(ref.data.home) --cov=tardis --cov-report=xml --cov-report=html
displayName: "TARDIS test"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes here, just the YAML autoformatter.

displayName: "TARDIS test"

- bash: |
bash <(curl -s https://codecov.io/bash)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML autoformatter.

Copy link
Contributor

@kaushik94 kaushik94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@gmail.com>
@wkerzendorf wkerzendorf merged commit 307611e into tardis-sn:master Aug 7, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* add GIT_LFS_SMUDGE

* fixed smudge command

* Minor changes

* Fetch refdata from GDrive backup

* Move fetch refdata steps to the top

* Fix typo

* Debugging pipeline

* Move fetch refdata steps again. Install gdown within TARDIS env

* [skip-ci] Minor changes

* Update azure-pipelines/simple_test_framework.yml

Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@gmail.com>

Co-authored-by: Kaushik Varanasi <kaushik.varanasi1@gmail.com>
Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants