Numba montecarlo tests merged #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d that when updating global variables use in numba functions, the numba functions must be recompiled in order for the changes to take effect. Keep this in mind when testing. The cases for full relativity being enabled SHOULD FAIL, there is a discrepancy between how the code is written and what the tests check. Someone who is more confident in their knowledge of the physics than me should check it out. (i.e. should we be off by a factor of doppler factor, or doppler factor squared?)
…dis into numba_unit_tests
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* Clean up error reporting formal integral * Make first move to numba montecarlo tests * Add doppler factor tests * Add mu, LF_TO_CMF tests * Change r_inner, r_outer names; reference plasma correctly in integral test * Clean up montecarlo testing * Move location of coverage file * Remove extraneous imports * Refer to previous plasma object for atomic data * Debug formal integral to ensure correct plasma is referenced * Adding runner to test fixture * Add capacity to use Estimators * Update r_packet.py * Added empty test files * Packet tests * Added empty tests for packet-related functions * Added update line estimator test * Nicer formatting * Added empty tests that assert False * Wrote unit tests for r_packet.move_r_packet. Should be noted, we found that when updating global variables use in numba functions, the numba functions must be recompiled in order for the changes to take effect. Keep this in mind when testing. The cases for full relativity being enabled SHOULD FAIL, there is a discrepancy between how the code is written and what the tests check. Someone who is more confident in their knowledge of the physics than me should check it out. (i.e. should we be off by a factor of doppler factor, or doppler factor squared?) * Bad vpacket test Co-authored-by: Arjun Savel <asavel@berkeley.edu> Co-authored-by: Jack O'Brien <jobrien585@gmail.com> Co-authored-by: Andrew Fullard <andrewgfullard@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.