Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare refdata with arbitrary labels #1430

Merged
merged 7 commits into from Jan 28, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jan 28, 2021

Description

Allow pipeline to compare two versions of the reference data by specifying labels (commit hashes, tags, branches, etc.).

  • If no label is specified, the pipeline will run as usual generating new reference data and comparing against the latest version stored in tardis-refdata repo.

  • Also I found a workaround to fetch LFS data from Azure Mirror with PAT.

It's working! See :http://opensupernova.org/~azuredevops/files/refdata-results/1430/d963e15e26a98f56b00778e44a016e547883f26a.html

Motivation and Context

Part of the CI/CD project.

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@epassaro
Copy link
Member Author

/AzurePipelines run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1430 (77779e1) into master (a6d190c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1430   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files          67       67           
  Lines        5521     5521           
=======================================
  Hits         3929     3929           
  Misses       1592     1592           
Impacted Files Coverage Δ
tardis/tardis/widgets/kromer_plot.py
tardis/tardis/widgets/sedec_plot.py 16.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fd51c...77779e1. Read the comment docs.

@azure-pipelines
Copy link

Build failed e3d4cf6

Click here to see results.

@epassaro
Copy link
Member Author

/AzurePipelines run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Build failed e6be808

Click here to see results.

@epassaro
Copy link
Member Author

/AzurePipelines run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Build failed 0c12d2a

Click here to see results.

@epassaro
Copy link
Member Author

/AzurePipelines run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Build succeeded 6bd2d57

Click here to see results.

@epassaro
Copy link
Member Author

/AzurePipelines run compare-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Build succeeded d963e15

Click here to see results.

@epassaro epassaro marked this pull request as ready for review January 28, 2021 12:26
@andrewfullard andrewfullard merged commit 1053c90 into tardis-sn:master Jan 28, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* initial commit

* change upstream url

* remove GIT_LFS_SKIP_SMUDGE=1

* update docs

* variables in yaml

* fix typos

* fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants