Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation guidelines hotfix #1431

Merged

Conversation

KevinCawley
Copy link
Contributor

Hotfix of black ticks

Description

Removed improper black ticks from being deployed

Motivation and Context

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1431 (3bf6098) into master (a6d190c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1431   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files          67       67           
  Lines        5521     5521           
=======================================
  Hits         3929     3929           
  Misses       1592     1592           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fd51c...3bf6098. Read the comment docs.

@jaladh-singhal
Copy link
Member

@andrewfullard please make sure this time to do "squash and merge" 😅

@andrewfullard andrewfullard merged commit 6f89804 into tardis-sn:master Jan 28, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Update documentation-build.yml

* Removed random sn

* Update documentation-build.yml

* Update CHANGELOG.md [skip ci]

* Update CHANGELOG.md [skip ci]

* Update CHANGELOG.md [skip ci]

* Hotfix to remove bad tick marks

* Undo edits from master

* Delete CHANGELOG.md

* Fixing changelog differences

* Fixing changelog differences from tardis

* Trying to undo changelog updates

Co-authored-by: TARDIS bot <wkerzendorf+tardis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants