Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing docs build problem #1569

Merged
merged 1 commit into from May 13, 2021
Merged

Conversation

isaacgsmith
Copy link
Member

@isaacgsmith isaacgsmith commented May 13, 2021

Description

Fixes the broken documentation build.

Motivation and context

After the merge of #1562 the documentation did not build properly.

How has this been tested?

  • Testing pipeline.
  • Other.
    Successfully built docs can be found here.

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1569 (b348a64) into master (6e31dc4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1569   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          73       73           
  Lines        6144     6144           
=======================================
  Hits         4120     4120           
  Misses       2024     2024           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e31dc4...b348a64. Read the comment docs.

@andrewfullard andrewfullard merged commit 130475c into tardis-sn:master May 13, 2021
@isaacgsmith isaacgsmith deleted the patch-1 branch June 1, 2021 14:54
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants