Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last interaction radius #1606

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Last interaction radius #1606

wants to merge 3 commits into from
+400 −1

Conversation

marxwillia
Copy link
Contributor

Description
Adding a new visualization tool which allows the user to see the location of the last line interaction of all packets in their TARDIS simulation. This allows the user to see exactly where in the ejecta certain lines transitions are predominantly occurring. This information can be used to adjust models to better fit observations.

Motivation and context
This new tool will allow users to better understand their models and fit to observed data more easily.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples
Below is an example plot showing the location distributions for a variety of elements/ions. This new tool will implement both matplotlib and plotly versions.

interaction_dist

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Before a PR is accepted, it must meet the following criteria:

  • Is the necessary information provided?
    • Does the PR have a complete description? Does it explain what the PR is attempting to do/fix, does it explain how it does this?
    • Is there an explanation of why this PR is needed?
    • Please use the TARDIS PR template
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be at or very close to 100%.
  • Is the code properly documented?
    • If this modifies existing code, then the docs should be updated. If this adds a new feature, additional documentation should be created.
    • Sphinx and docstrings in the code (in numpydoc format)
  • Does this conform to PEP 8 and the TARDIS style guidelines?
  • Does the PR fix the problem it describes?
    • Make sure it doesn’t e.g. just fix the problem for a specific case
    • Is this the best way of fixing the problem?
  • Is the code tidy?
    • No unnecessary print lines or code comments

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Before a PR is accepted, it must meet the following criteria:

  • Is the necessary information provided?
    • Does the PR have a complete description? Does it explain what the PR is attempting to do/fix, does it explain how it does this?
    • Is there an explanation of why this PR is needed?
    • Please use the TARDIS PR template
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be at or very close to 100%.
  • Is the code properly documented?
    • If this modifies existing code, then the docs should be updated. If this adds a new feature, additional documentation should be created.
    • Sphinx and docstrings in the code (in numpydoc format)
  • Does this conform to PEP 8 and the TARDIS style guidelines?
  • Does the PR fix the problem it describes?
    • Make sure it doesn’t e.g. just fix the problem for a specific case
    • Is this the best way of fixing the problem?
  • Is the code tidy?
    • No unnecessary print lines or code comments

@marxwillia marxwillia marked this pull request as draft June 2, 2021 20:41
@yuyizheng1112 yuyizheng1112 mentioned this pull request Jun 7, 2021
Closed
10 tasks
@jamesgillanders
Copy link
Member

It's been a while since this was discussed last, can we get some demo or minimum working example commands or something for how to use it?

@wkerzendorf
Copy link
Member

Will this die with packet tracking? @marxwillia can you comment - it also would need to be rebased.

@jamesgillanders
Copy link
Member

We are still interested in this generally. So we are not closing it, in the hopes that one of us (or a student/new contributor) picks it up and completes it

@Sumit112192
Copy link
Contributor

Sumit112192 commented Mar 8, 2024 •
edited

@jamesgillanders, @wkerzendorf, @marxwillia Can someone from the final year of undergraduate physics work on this? I don't know much about the theory of supernovas except that they are cool ( not in the sense of temperature, of course ). I have taken various Quantum Mechanics, Optics, Relativity, and Computational Physics courses. I am ready to put in the effort. I am fluent in programming in Python. Should I work on this?

@andrewfullard
Copy link
Contributor

@jamesgillanders, @wkerzendorf, @marxwillia Can someone from the final year of undergraduate physics work on this? I don't know much about the theory of supernovas except that they are cool ( not in the sense of temperature, of course ). I have taken various Quantum Mechanics, Optics, Relativity, and Computational Physics courses. I am ready to put in the effort. I am fluent in programming in Python. Should I work on this?

Yes, please make an attempt at the first objective!

@Charlie-1-3
Copy link

Dear @jamesgillanders , @wkerzendorf , @marxwillia and @andrewfullard

My name is Ayush Rai and I am currently pursuing a B.Tech+M.Tech degree in Mathematics and Computational Sciences at IITBHU, Varanasi. I am reaching out to express my interest in contributing to TARDIS through GSoC 2024.

I have a passion for open-source development and have some experience in group theory and mathematical modeling. I have also completed internships in creating Python modules and Data analytics. I am proficient in Python and enjoy implementing mathematical theories in other fields. I believe this skill and interest align well with the project.

I would be grateful if you could guide me in understanding the codebase by assigning some beginner-friendly tasks. Additionally, I would like to connect with mentors and other community members.

Thank you for your time and consideration.

Best regards,
Ayush Rai

@andrewfullard
Copy link
Contributor

Dear @jamesgillanders , @wkerzendorf , @marxwillia and @andrewfullard

My name is Ayush Rai and I am currently pursuing a B.Tech+M.Tech degree in Mathematics and Computational Sciences at IITBHU, Varanasi. I am reaching out to express my interest in contributing to TARDIS through GSoC 2024.

I have a passion for open-source development and have some experience in group theory and mathematical modeling. I have also completed internships in creating Python modules and Data analytics. I am proficient in Python and enjoy implementing mathematical theories in other fields. I believe this skill and interest align well with the project.

I would be grateful if you could guide me in understanding the codebase by assigning some beginner-friendly tasks. Additionally, I would like to connect with mentors and other community members.

Thank you for your time and consideration.

Best regards, Ayush Rai

Ayush, we have step-by-step instructions here https://tardis-sn.github.io/summer_of_code/gsoc_home/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaladh-singhal jaladh-singhal Awaiting requested review from jaladh-singhal

@jamesgillanders jamesgillanders Awaiting requested review from jamesgillanders

@MarkMageeAstro MarkMageeAstro Awaiting requested review from MarkMageeAstro

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marxwillia @jamesgillanders @wkerzendorf @Sumit112192 @andrewfullard @Charlie-1-3