Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mailmap and orcid #1631

Merged
merged 3 commits into from Jun 7, 2021
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 7, 2021

Description

Just updated .mailmap and .orcid.csv.

Motivation and context

A regular update to .mailmap.

It's important to remark that the Zenodo pipeline does not fail anymore when author names are incomplete or duplicates:

  • In case of incomplete names these authors does not count for the Zenodo metadata, and then are not recognized as TARDIS authors until someone fixes .mailmap.

  • In case of duplicate authors, the email with the highest number of commits is considered (until someone fixes .mailmap).

To see incomplete names or emails check the notebook artifact uploaded to the results of the Zenodo pipeline/action.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #1631 (151c6d5) into master (e062c69) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1631   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          73       73           
  Lines        6150     6150           
=======================================
  Hits         4133     4133           
  Misses       2017     2017           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e062c69...151c6d5. Read the comment docs.

@wkerzendorf wkerzendorf merged commit 145f157 into tardis-sn:master Jun 7, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* update mailmap

* update orcid.csv

* remove whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants