Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orchestrating continuous delivery pipeline #1775

Merged
merged 5 commits into from Aug 20, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Aug 11, 2021

Description

  • Removed the changelog from the release message. This changelog was different than the one created by the pipeline. It was generated by the Release Task from Azure Pipelines. I removed it to make it more consistent and keep just one changelog.
  • Removed the cron trigger from the changelog pipeline. Now this pipeline will be triggered when a new tag is pushed to the repository (through the release pipeline).
  • Removed [skip ci] tag from the commit message of the changelog pipeline.
  • Removed the cron trigger from the documentation build pipeline. This pipeline will be triggered by the changelog pipeline thanks to removing the commit message described above.

Now the complete delivery cycle can be described in the following way:

  1. Update zenodo.json (cron)
  2. Release (cron, 20' later)
  3. Post release changes, like changelog and other stuff such as updating CFF (triggered by pushing a new tag)
  4. Documentation update (by classic push to master trigger).

Motivation and context

This is required before adding the CITATION.cff file to the repository. This file should be updated through the pipeline too, so it's time to fix all the annoyances.

How has this been tested?

  • Testing pipeline.
  • Other.

We need to wait until next Saturday afternoon and see if this works ok.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #1775 (093267a) into master (1c3322b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1775   +/-   ##
=======================================
  Coverage   62.65%   62.65%           
=======================================
  Files          65       65           
  Lines        6036     6036           
=======================================
  Hits         3782     3782           
  Misses       2254     2254           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea86abf...093267a. Read the comment docs.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@epassaro
Copy link
Member Author

This should be merged soon if we don't want to wait another week.

@wkerzendorf wkerzendorf merged commit efe5042 into tardis-sn:master Aug 20, 2021
DhruvSondhi pushed a commit to DhruvSondhi/tardis that referenced this pull request Aug 21, 2021
* remove changelog from release message

* remove cron job from doc build

* remove cron job, run on new tag, commit without skip tag to trigger doc build

* remove if statement after removing cron job

* change commit message
DhruvSondhi pushed a commit to DhruvSondhi/tardis that referenced this pull request Aug 21, 2021
* remove changelog from release message

* remove cron job from doc build

* remove cron job, run on new tag, commit without skip tag to trigger doc build

* remove if statement after removing cron job

* change commit message
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* remove changelog from release message

* remove cron job from doc build

* remove cron job, run on new tag, commit without skip tag to trigger doc build

* remove if statement after removing cron job

* change commit message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants