Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for release task #1786

Merged
merged 4 commits into from Aug 26, 2021
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Aug 25, 2021

Description

  • Use inline option in release task, see this issue.
  • Added helper scripts to make pipeline more readable (and maintainable). Tested and working, see here.
  • Hide azure-pipelines folder (requires immediate action after merging).

Motivation and context

The pipeline was broken due to incorrect information displayed on Microsoft Azure's documentation.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@epassaro epassaro marked this pull request as draft August 25, 2021 22:07
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #1786 (5427618) into master (575002c) will not change coverage.
The diff coverage is n/a.

❗ Current head 5427618 differs from pull request most recent head 4f3f94a. Consider uploading reports for the commit 4f3f94a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1786   +/-   ##
=======================================
  Coverage   58.42%   58.42%           
=======================================
  Files          66       66           
  Lines        6684     6684           
=======================================
  Hits         3905     3905           
  Misses       2779     2779           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575002c...4f3f94a. Read the comment docs.

@epassaro epassaro marked this pull request as ready for review August 25, 2021 22:35
@tardis-bot
Copy link
Contributor

tardis-bot commented Aug 25, 2021

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@jaladh-singhal jaladh-singhal merged commit ef056ce into tardis-sn:master Aug 26, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* use correct inline option

* use helper scripts

* disable pr trigger

* hide azure pipelines folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants