Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed RPacketCollection Class to RPacketTracker #1861

Merged

Conversation

DhruvSondhi
Copy link
Contributor

@DhruvSondhi DhruvSondhi commented Jan 14, 2022

This PR aims to rename RPacketCollection to RPacketTracker Class.
Multiple variable names has also been changed to reflect this renaming.

In continuation of PR #1776.

How has this been tested?

  • Testing pipeline.
  • Other.

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above. -- Renaming of existing feature

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

Changed relevant variables names to refect this change
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

tardis/montecarlo/montecarlo_numba/base.py Outdated Show resolved Hide resolved
tardis/montecarlo/montecarlo_numba/base.py Outdated Show resolved Hide resolved
tardis/montecarlo/base.py Outdated Show resolved Hide resolved
@wkerzendorf
Copy link
Member

The test fail?

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #1861 (553141e) into master (6649e68) will not change coverage.
The diff coverage is n/a.

❗ Current head 553141e differs from pull request most recent head c8a151d. Consider uploading reports for the commit c8a151d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1861   +/-   ##
=======================================
  Coverage   62.12%   62.12%           
=======================================
  Files          66       66           
  Lines        6809     6809           
=======================================
  Hits         4230     4230           
  Misses       2579     2579           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6649e68...c8a151d. Read the comment docs.

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Wolfgang's suggestion and it's good to go.

@wkerzendorf wkerzendorf merged commit 3471658 into tardis-sn:master Jan 16, 2022
@DhruvSondhi DhruvSondhi deleted the rename_rpacketcollection_class branch January 17, 2022 05:44
DhruvSondhi added a commit to DhruvSondhi/tardis that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants