New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Broken Latex Code #1891
Fixing Broken Latex Code #1891
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1891 +/- ##
=======================================
Coverage 62.55% 62.55%
=======================================
Files 68 68
Lines 7127 7128 +1
=======================================
+ Hits 4458 4459 +1
Misses 2669 2669
Continue to review full report at Codecov.
|
Before a pull request is accepted, it must meet the following criteria:
|
Another `helium_treatment` option offered by TARDIS is `numerical-nlte`. The use of this plasma property requires an additional code that is the property of Stephan Hachinger (see arXiv:1201.1506) and is not distributed with TARDIS. TARDIS also requires a specific atomic datafile to use this module. This plasma option is included so that people who have access to and permission to use the necessary module may use it. Otherwise, the `recomb-NLTE` option provides a very accurate alternative approximation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What actually changed here? I can't tell from the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not edit or look at this section, so I'm not sure what, if anything, was changed here either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found that sometimes github just does that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally github does not change things. What does your local diff say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is potentially a different newline character due to this being edited via Jupyter Notebook on a Windows OS.
I think we should wait on this one until #1868 has been merged. That way we can rebase and check that this does fix the issue in the plasma graph. But it looks good to me |
Description
Places were latex code did not display correctly were updated to allow the code to display correctly.
Motivation and context
There were some places where code written in latex was formatted or written incorrectly
How has this been tested?
Examples
https://bartnikm.github.io/tardis-bartnikm/branch/latex-names/physics/setup/plasma/helium_nlte.html
Type of change
Checklist