Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Levels Index Variable Within Atomic Data Preperation #1957

Merged
merged 2 commits into from Apr 21, 2022

Conversation

bartnikm
Copy link
Contributor

Description

This removed the levels_index variable as well as a few other variables associated with it

Motivation and context

This aims to allow faster computing of the plasma state

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@bartnikm bartnikm changed the title Removing Levels Index Filter Removing Levels Index Variable Within Atomic Data Preperation Apr 13, 2022
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1957 (6e30517) into master (929b0ec) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1957      +/-   ##
==========================================
- Coverage   58.80%   58.78%   -0.02%     
==========================================
  Files          70       70              
  Lines        7853     7850       -3     
==========================================
- Hits         4618     4615       -3     
  Misses       3235     3235              
Impacted Files Coverage Δ
tardis/tardis/io/atom_data/base.py 89.53% <0.00%> (-0.18%) ⬇️
tardis/tardis/model/base.py 88.92% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bartnikm bartnikm marked this pull request as ready for review April 14, 2022 20:55
@wkerzendorf wkerzendorf merged commit 507c50f into tardis-sn:master Apr 21, 2022
@Rodot-
Copy link
Contributor

Rodot- commented May 4, 2022

Why was this PR made? These properties are required to run the continuum processes!

wkerzendorf pushed a commit that referenced this pull request May 4, 2022
…#1957)" (#2009)

This reverts commit 507c50f.

Co-authored-by: Andrew <andrewgfullard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants