Restructure code to remove the single_packet_seed field #2036
Conversation
|
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
Codecov Report
@@ Coverage Diff @@
## master #2036 +/- ##
=======================================
Coverage 58.34% 58.34%
=======================================
Files 76 76
Lines 8599 8593 -6
=======================================
- Hits 5017 5014 -3
+ Misses 3582 3579 -3
馃摚 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
What do you think @Rodot- |
| @@ -5,8 +5,8 @@ To facilitate more in-depth debugging when interfacing with the `montecarlo_numb | |||
| module, we provide a set of debugging configurations. PyCharm debugging | |||
| configurations, in addition to related scripts and .yml files, are contained in | |||
| `tardis.scripts.debug`. Currently, these include the ability to run TARDIS | |||
| in asingle-packet mode, with the packet seed identified at debug time. | |||
| `tardis_example_single.yml` is the configuration filethat is used to set up the | |||
| in a single-packet mode. | |||
There was a problem hiding this comment.
This will no longer be true with this change, correct? This particular documentation page is partially deprecated anyway, I think, and should be addressed in a separate PR.
|
|
||
| with open(yaml_file, "w") as f: | ||
| yaml.safe_dump(params, f) | ||
| yaml_file = "tardis_example_single.yml" |
There was a problem hiding this comment.
Note to other reviewers- this test will need to be addressed in detail in the future.
|
Please make sure the updated files pass the black check and add yourself to the mailmap. Other than that, this is looking good as it's passing the tests. |
rohithvarma3000
force-pushed
the
restructure-1902
branch
from
b809570
to
44a37cb
Compare
|
I have made all updates as per the discussions. Please have another look into the PR |
馃摑 Description
Type: 馃
bugfixRestructure the code to remove the single_packet_seed field in code, yml and documentation. Fixes #1902 . The single_packet_seed is creating some unexpected bugs. Continuation of #1926
馃搶 Resources
Examples, notebooks, and links to useful references.
馃殾 Testing
How did you test these changes?
pytest tardis
鈽戯笍 Checklist
build_docslabel