Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop redirecting docs page #2046

Merged
merged 4 commits into from Jun 7, 2022
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 7, 2022

📝 Description

Type: 🪲 bugfix | 🎢 infrastructure

Recently @nolanbrown01 found there are some broken links in the documentation due to redirecting the root of the page to /latest. Also, I found most of the links found in Google to the documentations are broken for the same reason.

This redirecting feature was implemented thinking in a wider project, I don't think we need that.

Also, I set up the pipeline to clean the gh-pages branch when triggered manually.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

Tested extensively on my fork's gh-pages branch.

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@epassaro epassaro marked this pull request as ready for review June 7, 2022 17:27
@andrewfullard andrewfullard added this to In progress in Documentation via automation Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2046 (42a7e66) into master (2b220af) will not change coverage.
The diff coverage is n/a.

❗ Current head 42a7e66 differs from pull request most recent head 02a79d2. Consider uploading reports for the commit 02a79d2 to get more accurate results

@@           Coverage Diff           @@
##           master    #2046   +/-   ##
=======================================
  Coverage   59.87%   59.87%           
=======================================
  Files          70       70           
  Lines        8157     8157           
=======================================
  Hits         4884     4884           
  Misses       3273     3273           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro epassaro merged commit 258ac90 into tardis-sn:master Jun 7, 2022
Documentation automation moved this from In progress to Done Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants