Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin geometry subfolder #2067

Merged

Conversation

nolanbrown01
Copy link
Contributor

@nolanbrown01 nolanbrown01 commented Jun 22, 2022

📝 Description

Type: 🎢 infrastructure

Created geometry and montecarlo subfolders of transport. Moved calculate_distances into geometry subfolder. Renamed dependencies.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #2067 (9c4929b) into master (a8bad89) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2067   +/-   ##
=======================================
  Coverage   58.34%   58.34%           
=======================================
  Files          76       76           
  Lines        8593     8593           
=======================================
  Hits         5014     5014           
  Misses       3579     3579           
Impacted Files Coverage Δ
tardis/transport/geometry/calculate_distances.py 34.88% <ø> (ø)
...lo_numba/continuum/r_packet_transport_continuum.py 15.15% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/vpacket.py 21.78% <100.00%> (ø)
tardis/transport/r_packet_transport.py 20.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@nolanbrown01 nolanbrown01 marked this pull request as ready for review June 22, 2022 19:16
@andrewfullard andrewfullard merged commit fb245c3 into tardis-sn:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants