Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New TARDIS flowchart and cleaning up physics walkthrough #2111

Merged
merged 4 commits into from Aug 9, 2022

Conversation

isaacgsmith
Copy link
Member

@isaacgsmith isaacgsmith commented Aug 4, 2022

📝 Description

Type: 📝 documentation

Three main changes:

  • Adding a new TARDIS flowchart to the physics walkthrough introduction.
  • Moving the gamma ray deposition pages to their appropriate spot (and adding a bibtex entry to a missing citation in one of those pages).
  • Fixing some issues with the light and matter page (specifically renaming kappa to alpha for opacity, and referencing the page where necessary).

📌 Resources

Main edited page:
https://tardis-sn.github.io/tardis/pull/2111/physics/intro/index.html

Other edited sections:
https://tardis-sn.github.io/tardis/pull/2111/contributing/in_progress/index.html#simulate-supernovae-in-the-nebular-phase
https://tardis-sn.github.io/tardis/pull/2111/physics/intro/light_and_matter.html#opacity-and-optical-depth
https://tardis-sn.github.io/tardis/pull/2111/physics/montecarlo/propagation.html#physical-interactions

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)
    Docs built on GitHub.

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #2111 (ee49ddb) into master (973f9a5) will not change coverage.
The diff coverage is n/a.

❗ Current head ee49ddb differs from pull request most recent head 29aa332. Consider uploading reports for the commit 29aa332 to get more accurate results

@@           Coverage Diff           @@
##           master    #2111   +/-   ##
=======================================
  Coverage   61.45%   61.45%           
=======================================
  Files          75       75           
  Lines        8617     8617           
=======================================
  Hits         5296     5296           
  Misses       3321     3321           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@isaacgsmith isaacgsmith marked this pull request as ready for review August 4, 2022 02:28
@wkerzendorf wkerzendorf merged commit d1632db into tardis-sn:master Aug 9, 2022
@isaacgsmith isaacgsmith deleted the new_physics_flowchart branch August 10, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants