Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port update reference data pipeline to GitHub Actions #2249

Merged
merged 15 commits into from Apr 4, 2023

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Mar 20, 2023

📝 Description

Type: 🎢 infrastructure

This GA workflow replaces the Azure update-refdata pipeline, and does exactly the same job: using the slash command /update-refdata the workflow is called, generates new reference data based on the changes made in the pull request, and then opens a new pull request in the tardis-refdata repository proposing these changes.

  • Create new dispatch.yml workflow to allow running other workflows via slash commands
  • Create new update-refdata.yml workflow
  • Deleted the Azure Pipeline's YAML file
  • Patched the Arepo tests to skip generating reference data

Closes #2251

📌 Resources

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

Tested on my fork:

It's unlikely that this workflow works out of the box, but it was tested as much as possible.

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@epassaro epassaro changed the title Port update reference data pipweline to GitHub Actions Port update reference data pipeline to GitHub Actions Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #2249 (b85ceee) into master (4ff230e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b85ceee differs from pull request most recent head 790f32e. Consider uploading reports for the commit 790f32e to get more accurate results

@@           Coverage Diff           @@
##           master    #2249   +/-   ##
=======================================
  Coverage   71.82%   71.82%           
=======================================
  Files         133      133           
  Lines       12358    12360    +2     
=======================================
+ Hits         8876     8878    +2     
  Misses       3482     3482           
Impacted Files Coverage Δ
tardis/io/tests/test_arepo_parser.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tardis-bot
Copy link
Contributor

tardis-bot commented Mar 20, 2023

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@epassaro epassaro force-pushed the ci/update-refdata-ga branch 2 times, most recently from 9606d99 to 2ad8b10 Compare March 21, 2023 13:06
@epassaro epassaro requested a review from AlexHls March 21, 2023 21:17
@epassaro epassaro self-assigned this Mar 21, 2023
@epassaro epassaro marked this pull request as ready for review March 21, 2023 21:27
@andrewfullard
Copy link
Contributor

Could you write a short summary (or just docs) describing what the refdata pipeline does now? Is it identical to the Azure version in steps?

@epassaro
Copy link
Member Author

Could you write a short summary (or just docs) describing what the refdata pipeline does now? Is it identical to the Azure version in steps?

Yes, I could write a summary in the PR body.

This is just a port of the pipeline that generates new reference data and opens a pull request in the tardis-refdata repository.

I'm planning to port compare-refdata pipeline after this (it's a bit more complicated), and then update the entire CI/CD section of the documentation that is very, very outdated.

andrewfullard
andrewfullard previously approved these changes Mar 22, 2023
Copy link
Member

@atharva-2001 atharva-2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR!

@andrewfullard andrewfullard merged commit 6cf502f into tardis-sn:master Apr 4, 2023
6 of 7 checks passed
light2802 pushed a commit to light2802/tardis that referenced this pull request May 27, 2023
* Create new workflow

* Patch for arepo tests

* Restore deleted parameter

* Black format; Add missing skip reason

* Fix typo in comment

* Add more comments

* Create slash command dispatcher

* Changes to dispatcher

* Black format

* Adapt workflow to run on workflow dispatch; create pull request step

* Black format

* Minor fixes

* Add bot comments after result

* Remove Azure Pipelines YAML file

* Do not push .lfs-assets-id on pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Arepo tests break pytest --generate-reference flag
4 participants