Make nthreads a property of MontecarloRunner instead of Simulation class

[xansh]

📝 Description

Type:🎢 restructure

Made nthreads a property of MontecarloRunner instead of passing it from Simulation

🚦 Testing

How did you test these changes?

• Testing pipeline
• Other method (describe)
• My changes can't be tested (explain why)

☑️ Checklist

• I requested two reviewers for this pull request
• I updated the documentation according to my changes
• I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

[tardis-bot]

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

[xansh]

Hi @wkerzendorf @andrewfullard

Can you please review this?

Thanks!

[codecov]

Codecov Report

Merging #2311 (b275063) into master (846ef7c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b275063 differs from pull request most recent head 6863d4f. Consider uploading reports for the commit 6863d4f to get more accurate results

@@           Coverage Diff           @@
##           master    #2311   +/-   ##
=======================================
  Coverage   71.96%   71.97%           
=======================================
  Files         137      137           
  Lines       12514    12516    +2     
=======================================
+ Hits         9006     9008    +2     
  Misses       3508     3508           

Impacted Files	Coverage Δ
tardis/io/model_reader.py	67.49% <ø> (ø)
tardis/simulation/base.py	83.92% <ø> (-0.08%)	⬇️
tardis/io/tests/test_model_reader.py	97.90% <100.00%> (+0.01%)	⬆️
tardis/montecarlo/base.py	87.08% <100.00%> (+0.10%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[wkerzendorf]

looks good except potentially nthreads=1