Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctest #262

Closed
wants to merge 4 commits into from
Closed

Ctest #262

wants to merge 4 commits into from

Conversation

vaibhav4595
Copy link

Temporarily, conftest has been added in this particular src directory(Works well this way"
Right now """""make test"""" runs the tests from the src directory.
A way to incorporate this in the main conftest.py in the tardis directory is needed
Then the next step is to incorporate this with setup.py test

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 720349b on vaibhav4595:ctest into dca3806 on tardis-sn:master.

@vaibhav4595
Copy link
Author

@wkerzendorf Please do have a look at this. I have temporarily added files inside the src directory itself.
There is a function which checks the constant value of C from the cmontecarlo.h file .
Right now I have added the conftest.py inside the src itself. The command 'make test' from the src directory right now calls py.test to test the particular function.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.1% when pulling 720349b on vaibhav4595:ctest into dca3806 on tardis-sn:master.

@wkerzendorf
Copy link
Member

@vaibhav4595 it's fine to have multiple conftests in the structure. I think however that a call to python setup.py test should call the tests that you created. This is not the case yet 😉

@vaibhav4595
Copy link
Author

@wkerzendorf I have got to work it on my machine now. Soon will be creating another PR.

@wkerzendorf
Copy link
Member

@vaibhav4595 if you don't need this PR anymore - can we close it?

@vaibhav4595
Copy link
Author

@wkerzendorf Yes sure we can. I am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants