Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an overview page on Dokuwiki. #630

Merged
merged 5 commits into from Aug 3, 2016

Conversation

kdexd
Copy link

@kdexd kdexd commented Jul 21, 2016

This PR introduces maintenance of an overview page on our Integration Tests Dokuwiki. It is selected as the landing page of the wiki.
Each time a report it uploaded n Wiki, its information in appended on this page.
Information includes commit hash, commit message description, start time in UTC, time elapsed, and status of test run (pass / fail / error).

@kdexd
Copy link
Author

kdexd commented Jul 21, 2016

@wkerzendorf @yeganer This one is ready from my side, it is a simple enhancement.

@wkerzendorf
Copy link
Member

@yeganer any other questions on this one?

@yeganer
Copy link
Contributor

yeganer commented Jul 25, 2016

@wkerzendorf Looks good to me.

@@ -67,14 +70,16 @@ def __init__(self, dokuwiki_details):
else:
self.dokuwiki_url = dokuwiki_details["url"]

def pytest_sessionstart(self, session):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need this as you should be able to convert suite_start_time to utc

Copy link
Author

@kdexd kdexd Jul 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeganer suite_start_time is time zone unaware hence I cannot directly convert it to UTC. I won't have any idea how much offset is to be added / subtracted. Hardcoding +0200 according to CEST and subtracting the hours may not be a good idea either, I am in +0530 while debugging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you confirmed that the line has any effect?
Because I assume super(DokuReport, self).pytest_sessionstart(session) does the same thing.
This will essentially overwrite the previously defined self.suite_start_datetime

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a method which could do the trick, I updated it in my subsequent commit.

@yeganer yeganer merged commit 3e55c13 into tardis-sn:master Aug 3, 2016
@kdexd kdexd deleted the dokuwiki-overview-page branch August 3, 2016 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants