Fix for PR #801 #802
Merged
Fix for PR #801 #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vg3095 - thank you very much! |
vg3095
commented
Nov 10, 2017
| @@ -349,20 +349,4 @@ def calculate(self, phi, partition_function, number_density, | |||
| 1].sum(axis=0)) | |||
| ion_number_density.ix[2].ix[2].update(helium_population_updated.ix[ | |||
| 2].ix[0]) | |||
| ion_numbers = ion_number_density.index.get_level_values(1).values | |||
There was a problem hiding this comment.
I think this code block is not required when electron_densities are read from a seperate file in IonNumberDensityHeNLTE class.
There was a problem hiding this comment.
@vg3095 well often it isn't - we need to be careful here. It needs to calculate them if they are not given. They will often not be given.
There was a problem hiding this comment.
@wkerzendorf
See this line, and here, I have removed this code block from second link (from else part --> if electron_densities is present).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.