Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiative recombination #933

Merged
merged 10 commits into from May 22, 2019
Merged

Conversation

chvogl
Copy link
Contributor

@chvogl chvogl commented May 17, 2019

No description provided.

Copy link
Member

@wkerzendorf wkerzendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good - no tests though - but I guess we are forgoing them until everything plays together.


photoionization_data: pandas.DataFrame
A DataFrame containing the *photoionization data* with:
index: no index;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really?


logger = logging.getLogger(__name__)

njit_dict = {'fastmath': False, 'parallel': False}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should think if we want to have a central one

@@ -275,3 +301,20 @@ class PartitionFunction(ProcessingPlasmaProperty):
def calculate(self, level_boltzmann_factor):
return level_boltzmann_factor.groupby(
level=['atomic_number', 'ion_number']).sum()


class ThermalLTEPartitionFunction(PartitionFunction):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite clear why we need to have them called ThermalLTE - as LTE means Local Thermal Equilibrium

class TInner(Input):
outputs = ('t_inner',)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

streber!

@wkerzendorf wkerzendorf merged commit 9af7d7b into tardis-sn:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants