Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undocumented "files" parameter for htpasswd and enhance doc #73

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

magikstm
Copy link
Contributor

This is a fix for #39.

It removes an undocumented parameter and enhances the doc in the main page on a related feature.

@coveralls
Copy link

coveralls commented Mar 11, 2018

Coverage Status

Coverage decreased (-0.02%) to 91.283% when pulling 22cfd86 on magikstm:Issue-39 into 8d1a006 on tarent:master.

@smancke
Copy link
Contributor

smancke commented Mar 14, 2018

@vschmi Are you fine with this, or do you still use this 'files' parameter?

@smancke
Copy link
Contributor

smancke commented Dec 26, 2018

@domano
Can you please check, if you are still using the files parameter in your config, or if we can remove it?

@domano
Copy link
Contributor

domano commented Feb 2, 2019

I will look at it next week and update the PR. Sorry, i've just seen the PR

@magikstm
Copy link
Contributor Author

I suggest merging this PR and closing the related issue.

It'll document a feature and anyone using the undocumented one that disappears will be able to use that one instead.

@magikstm
Copy link
Contributor Author

magikstm commented Jan 9, 2020

I suggest reviewing this PR again and possibly merging it to enhance the documentation.

@g-w g-w merged commit 3daa252 into qvest-digital:master Mar 12, 2020
@g-w
Copy link
Contributor

g-w commented Mar 12, 2020

I will merge this PR. Since there was no objections against merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants