Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing text domains #105

Closed
yoancutillas opened this issue May 9, 2020 · 0 comments
Closed

Missing text domains #105

yoancutillas opened this issue May 9, 2020 · 0 comments

Comments

@yoancutillas
Copy link
Contributor

Hello,

In includes/Widget.php lines 47, 48 (twice) and 54,

there are four missing text domains, can you add them?

  • _x( 'Search for:', 'label', 'wedocs' )
  • esc_attr_x( 'Documentation Search …', 'placeholder', 'wedocs' )
  • esc_attr_x( 'Search for:', 'label', 'wedocs' )
  • esc_attr_x( 'Search', 'submit button', 'wedocs' )

because these strings cannot be translated otherwise.

Thank you!
tareq1988 added a commit that referenced this issue Jun 5, 2020
@tareq1988
Merge tag 'v1.6.1' into develop
04488f2 
 * **New:** Load CSS and JS files only for Docs. Fixes [#104](#104)
 * **Fix:** Added missing textdomains. Fixes [#105](#105)
 * **Fix:** Fix search API. Was breaking due to namespace issue with WP_Query. Fixes [#108](#108)
star219 pushed a commit to star219/wpdocs_plugin that referenced this issue Dec 25, 2022
@tareq1988
Merge tag 'v1.6.1' into develop
8f48e29 
 * **New:** Load CSS and JS files only for Docs. Fixes [#104](weDevsOfficial/wedocs-plugin#104)
 * **Fix:** Added missing textdomains. Fixes [#105](weDevsOfficial/wedocs-plugin#105)
 * **Fix:** Fix search API. Was breaking due to namespace issue with WP_Query. Fixes [#108](weDevsOfficial/wedocs-plugin#108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yoancutillas