Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Correction #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Transaction Correction #35

wants to merge 2 commits into from

Conversation

jhorlima
Copy link

No description provided.

@devonbessemer
Copy link
Contributor

devonbessemer commented May 31, 2017

I would argue that the previous merge of #30 should be reverted. Excluding the errors introduced by the merge, exceptions should not be thrown in unprepared and many of these methods in accordance with ConnectionInterface, the only methods that should throw an exception are documented with @throws so it does not violate the Liskov substitution principle. My goal by introducing these methods in #27 was to align it closer with Eloquent. #30 also refactored the code away from WP's conventions.

@N00BEST
Copy link

N00BEST commented Nov 8, 2020

This solved the problem specified in #77. Although, this file has some errors beside the ones pointed by devonblzx. I replace my Database.php file with this and was missing cursor implementation and $userReadPdo in select and selectOne functions definition.

I don't know if this could be merged or how to contribute in order for it to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants