Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Subchannel Posting Should Not Error Entire Process #102

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

therynamo
Copy link
Contributor

Description

#99 was supposed to fix the issues with error handling, but it turns out the errors were not bubbling as expected and we were still getting unhandled promise rejections. It was clear that we didn't need to bomb the process if the message sending failed, since we run a post to comment routine after posting. So this PR removes unnecessary error throwing and provides clearer messaging.

Motivation and Context

^

How Has This Been Tested?

  • unit tests?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (updating repository quality of life, like deps, linting, etc.)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@therynamo therynamo added the 🐛 fix Something isn't working label Mar 13, 2021
@therynamo therynamo self-assigned this Mar 13, 2021
@therynamo therynamo merged commit 97562c1 into master Mar 13, 2021
@therynamo therynamo deleted the fix-cl-release branch March 13, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 fix Something isn't working
Projects
Captain's Log Workstream
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants