Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont log channel url in error message #116

Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix: dont log channel url in error message #116

merged 1 commit into from
Jul 6, 2021

Conversation

rdmulford
Copy link
Collaborator

@rdmulford rdmulford commented Jul 6, 2021

Description

resolves #115

Motivation and Context

I saw a slack token url secret being logged in CI after a task failed, so wanted to make sure we aren't logging secrets.

How Has This Been Tested?

minor change in logging

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (updating repository quality of life, like deps, linting, etc.)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@rdmulford rdmulford requested a review from therynamo July 6, 2021 17:24
@therynamo therynamo merged commit 686c39a into master Jul 6, 2021
@therynamo therynamo deleted the log-token branch July 6, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(security): slack URL token being logged in error message
2 participants