More thorough tests of regex #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneded character in regex
therynamo
suggested changes
Dec 13, 2019
| @@ -46,12 +46,29 @@ describe('ticketFinder', () => { | |||
| }); | |||
|
|
|||
| it('should find Jira ticket when there are tickets in the branch name only', async () => { | |||
| const tickets = await ticketFinder({ body: mockBodyWithNothing, head: { ref: 'therynamo/JIRA-123' } }); | |||
| // ticket id only | |||
| var tickets = await ticketFinder({ body: mockBodyWithNothing, head: { ref: 'JIRA-123' } }); | |||
There was a problem hiding this comment.
Suggested change
| var tickets = await ticketFinder({ body: mockBodyWithNothing, head: { ref: 'JIRA-123' } }); | |
| let tickets = await ticketFinder({ body: mockBodyWithNothing, head: { ref: 'JIRA-123' } }); |
There was a problem hiding this comment.
The linter should have caught this, but usually we want to "prefer let".
therynamo
approved these changes
Dec 13, 2019
therynamo
pushed a commit
that referenced
this pull request
Mar 15, 2021
* More thorough tests of regex Remove unneded character in regex * let for var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneded character in regex