Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support capitalized github keywords #94

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

AndersDJohnson
Copy link
Contributor

Description

This PR adds case-insensitivity to the regular expression that looks for GitHub keywords (Close(s), Fix(es), Resolve(s)) in PR descriptions.

Motivation and Context

I noticed (I think) that we were possibly missing detection of capitalized GitHub keywords (Close(s), Fix(es), Resolve(s)). This is supported by GitHub so we should support it.

How Has This Been Tested?

  • unit tests?

❌ Failing before:

Screen Shot 2021-02-03 at 9 02 45 AM

✅ Passing after:

Screen Shot 2021-02-03 at 9 11 00 AM

Screenshots (if appropriate):

Screen Shot 2021-02-03 at 9 09 04 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (updating repository quality of life, like deps, linting, etc.)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@therynamo therynamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EZ

@therynamo therynamo merged commit b94266c into master Feb 3, 2021
@therynamo therynamo deleted the github-keywords-capitalized branch February 3, 2021 16:03
@AndersDJohnson AndersDJohnson added the 🐛 fix Something isn't working label Feb 3, 2021
therynamo pushed a commit that referenced this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants